Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): use WDS colors tokens - WF-149 #696

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Dec 16, 2024

Introduce the WDS tokens as CSS variable and use it in the application. The purpose is to uniformize and spread the usage of Writer Design System and prepare the dark mode.

It's mainly a big "search and replace" from HEX colors to CSS vars. But I also replaced some non-WDS colors by the closest equivalent (when it was almost no noticeable).

No big design changes are expected.

@madeindjs madeindjs self-assigned this Dec 16, 2024
@ramedina86
Copy link
Collaborator

If you're going for unification you can try v-bind to use the TypeScript values inside CSS.

@ramedina86
Copy link
Collaborator

You can also do a forEach and just dump them in a style, since these will be injected at the very top and not changed downstream.

@madeindjs madeindjs force-pushed the WF-149 branch 2 times, most recently from 3139836 to b2ea595 Compare December 16, 2024 14:48
@madeindjs
Copy link
Collaborator Author

You can also do a forEach and just dump them in a style, since these will be injected at the very top and not changed downstream.

@ramedina86 , good idea! I implemented it in 3ff5303

@madeindjs madeindjs marked this pull request as ready for review December 16, 2024 17:04
@ramedina86 ramedina86 merged commit 22d0248 into writer:dev Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants